search

zotero / zotero-standalone-build

Zotero client build utility
https://www.zotero.org/support/dev/client_coding/building_the_standalone_client
Other
119 stars 98 forks source link

add missing string conversion #97

Closed prototype99 closed 2 years ago

prototype99 commented 2 years ago

without this the build fails like so:

Deoptimized 183/1273 in ./omni.ja
Traceback (most recent call last):
  File "/var/tmp/pamac-build-seirra/zotero-git/src/zotero-standalone-build/scripts/optimizejars.py", line 376, in <module>
    main()
  File "/var/tmp/pamac-build-seirra/zotero-git/src/zotero-standalone-build/scripts/optimizejars.py", line 370, in main
    deoptimize(JAR_LOG_DIR, IN_JAR_DIR, OUT_JAR_DIR)
  File "/var/tmp/pamac-build-seirra/zotero-git/src/zotero-standalone-build/scripts/optimizejars.py", line 360, in deoptimize
    open(logfile, "wb").write("\n".join(log).encode('utf-8'))
TypeError: sequence item 0: expected str instance, bytes found
==> ERROR: A failure occurred in build().

the python version used was 3.10.4

dstillman commented 2 years ago

Thanks — look like https://github.com/zotero/zotero-standalone-build/commit/e3396b16607455c95e7009342971309e340cbb89 was sufficient for macOS and Windows, but on Linux optimizejar() returns an array of filenames for some reason and needs this.