calling erlang:nif_error when nif is not loaded

zotonic / ua_classifier

User-Agent Classifier: Erlang version of WeatherChannel's dClass

Apache License 2.0

5 stars 8 forks source link

calling erlang:nif_error when nif is not loaded #4

Closed AnushaMorappanavar closed 7 years ago

AnushaMorappanavar commented 7 years ago

This PR calls erlang:nif_error(Reason) when nif is not loaded, so that Dialyzer does not generate false warnings.

More details on erlang:nif_error -> http://erlang.org/doc/man/erlang.html#nif_error-1

mworrell commented 7 years ago

Hi @AnushaMorappanavar, sorry for the slow reaction and thanks for your merge request!

AnushaMorappanavar commented 7 years ago

Thanks Mark!

On Fri, Nov 10, 2017 at 3:39 AM Marc Worrell notifications@github.com wrote:

Merged #4 https://github.com/zotonic/ua_classifier/pull/4.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zotonic/ua_classifier/pull/4#event-1335895870, or mute the thread https://github.com/notifications/unsubscribe-auth/AVGOdy6424iM6OQEP417mt-dX8ECFHOoks5s1DXqgaJpZM4QFEO8 .