Run only in watch by default

stephencookdev commented 6 years ago

What changes are you making...

feature for https://github.com/zouhir/jarvis/issues/117 and https://github.com/zouhir/jarvis/issues/120

What is the current behavior?

Currently Jarvis runs both in run mode, and watch mode. But in run mode, it obviously runs, and then just dies once the build is complete (which is a bit odd, for default behaviour).

What is the new behavior?

Rather than explicitly saying that we want Jarvis to either die/stay alive at the end of a build run, this PR assumes that the default behaviour for Jarvis should be to stay alive if it boots up. Instead, it tries to be intelligent in not booting up at all (by default) in build mode.

Setting the watchOnly option to false will change this, making Jarvis run (and stay open) in build mode

Are you making a breaking change?

Yes, Jarvis will now by default not run at all unless it's in watch mode. However, I can't really think of a good reason to expect Jarvis to run in non-watch mode at the moment (as the port will suddenly die on you if you're not quick enough to beat webpack's build)

zouhir commented 6 years ago

I approve the changes, just merged your previous PRs, can you please double check this PR still works as expected and no conflicts, I'd super appreciate your help!

stephencookdev commented 6 years ago

Thanks @zouhir :) I've fixed up the branch, should be fine to merge if you're happy with it

zouhir / jarvis