search

zouhir / jarvis

A very intelligent browser based Webpack dashboard
5.44k stars 191 forks source link

Use uWS in Socket.io? #129

Open kurtextrem opened 6 years ago

kurtextrem commented 6 years ago

See this issue on why: https://github.com/socketio/engine.io/issues/388 And here how: https://github.com/socketio/engine.io#methods

lukeed commented 6 years ago

We technically could, but the performance aspect doesn't matter at all in JARVIS. Memory efficiency would be the only benefit.

Personally I'd probably swap to ws for this project since it's a little lighter on the install (no binary) and there's still a lot of performance improvement.

That said, we'd need to add a websocket listener on the client, which Sockette could do.

All in all, this is mostly a yak shaver because we don't really gain anything from it. It's not like JARVIS is powering an application server or something -- then it'd matter 😄

zouhir commented 6 years ago

I totally don't like socket.io but I can't prioritise swapping it now as we still in beta and am really rethinking so many things