search

zouhir / jarvis

A very intelligent browser based Webpack dashboard
5.44k stars 191 forks source link

Fix some CSS issues with the table component #67

Closed monsonjeremy closed 6 years ago

monsonjeremy commented 6 years ago

The first commit in this PR is to fix the overlapping module path and details (three dots) button. I've applied a small fix by overriding some styles, this isn't the best approach but I didn't want to entirely override all the other sections as well. If that's the preferred solution, i'm more than willing to do that as well.

The second commit is a small fix to allow users to scroll all the way to the bottom of the list of modules in the table. Currently the last few modules in the list were hidden, therefore the padding allows the user to bring the last one into view.

zouhir commented 6 years ago

Ohhhhh beauty!

1 question to confirm before I merge! I can see the 3 dots width is fixed to 60px which is good just bytes number, will it expand a bit to support slightly bigger number?

otherwise LGTM 🙏

monsonjeremy commented 6 years ago

So currently it looked like the width of the 3 dots was fixed to 30px. For some reason with the flexbox fix, 30px was not wide enough so i override it to 60px. As long as the icon itself does not change the fixed values should be fine!

zouhir commented 6 years ago

TO MERGEEEEEEEEEEEEEEEE!!!!!!!!!! 🎉🎉🎉🎉🎉