zouhir / jarvis

A very intelligent browser based Webpack dashboard
5.44k stars 191 forks source link

UI refactor #83

Closed Khachatour closed 6 years ago

Khachatour commented 6 years ago

I will be pleased if you allow me to continue work on UI :)

Khachatour commented 6 years ago

@Pickra Can you please review last commit, I think this one is pretty okay way to use If component!

zouhir commented 6 years ago

That's looking good! I still think If shouldn't be at the index of utils and maybe prepare the index inside utils to export multiple components for the soon future

zouhir commented 6 years ago

also @Khachatour : if you are interested in continuing working on the UI please join us on discord! https://discord.gg/tdc9p4

Khachatour commented 6 years ago

@zouhir I agree with you, thats a good idea, make a index as interface and use all other util components from there, yep!

Khachatour commented 6 years ago

@zouhir I did that in the last commit, by now I got rid of index.js file, because we have only one utility component for now. For a future I will bring back index.js as interface for all utility components! :) what you think ?

zouhir commented 6 years ago

Looks great!, doing some manual testing now

Khachatour commented 6 years ago

Great!

Khachatour commented 6 years ago

@zouhir hey any other changes you need ? :)