search

zouhir / jarvis

A very intelligent browser based Webpack dashboard
5.44k stars 191 forks source link

Missing support for host #93

Closed Milanzor closed 6 years ago

Milanzor commented 6 years ago

Right now, there is no way to change what IP/host the HTTP server listens to.

I have Webpack + JARVIS running on a server in my network, but because there's no option to change what IP the JARVIS HTTP server listens to, it is inaccessible from devices in the network.

Reading the server.js and index.js in your src folder, it seems it can be achieved quite simply, so I tried to fork+pull request but am not able to properly build your code through the commands in the package.json (you have 2 of these btw, 1 in the root and 1 in the src folder).

Perhaps you can point me in the right direction or make a contribution guide, I'd be happy to add this myself and submit it through a pull request, but can't do that if I can't build and test it.

Thanks!

Milanzor commented 6 years ago

Figured out the build script doesn't run on Ubuntu 16.04 (Node 8.9.3, NPM 5.5.1, I should probably update...) but I got it working on my MacBook.

Will send PR

Milanzor commented 6 years ago

Added PR #94

zouhir commented 6 years ago

Merged!