zouhir / jarvis

A very intelligent browser based Webpack dashboard
5.44k stars 191 forks source link

Added listen-host to server #94

Closed Milanzor closed 6 years ago

Milanzor commented 6 years ago

As described in issue #93, this PR adds support for a host option, so JARVIS can be access in a network.

zouhir commented 6 years ago

@lukeed quick confirmation: would that be ok with Polka changes?

Milanzor commented 6 years ago

@zouhir Pulled in your changes (moved to Polka) and added the host option for Polka

Also, I think I'm missing something, the bin folder is in the .gitignore but in package.json, the "main" entry is bin/plugin/index.js, how do those files get updated?

zouhir commented 6 years ago

Thank you!!👏😻🙌🙌.

About bin: that gets updated when we build & publish but it has the package artifacts which we don't know to be tracked in git! Awesome to notice that!