search

zouhir / lqip

Low Quality Image Placeholders (LQIP) Module for Node
433 stars 30 forks source link

Update Sharp to latest version #7

Closed jalamprea closed 6 years ago

jalamprea commented 6 years ago

With the latest version of Sharp, there are some bugs fixed and some debug messages removed

axe312ger commented 6 years ago

And most important: It adds support for prebuilt binaries to speed up installation :)

http://sharp.pixelplumbing.com/en/stable/changelog/#v0200-5th-march-2018

axe312ger commented 6 years ago

@zouhir having the old sharp version results in a native library collision when using lqip together with other modules already updated to sharp 0.20

This very simple PR would fix it. Please merge and release 🚀 

module.js:689
  return process.dlopen(module, path.toNamespacedPath(filename));
                 ^

Error: dlopen(.../node_modules/sharp/build/Release/sharp.node, 1): Library not loaded: @rpath/libvips-cpp.42.dylib
  Referenced from: .../node_modules/sharp/build/Release/sharp.node
  Reason: Incompatible library version: sharp.node requires version 51.0.0 or later, but libvips-cpp.42.dylib provides version 50.0.0
zouhir commented 6 years ago

Will merge and release in upcoming few hours! Nice update, thanks!

josenobile commented 6 years ago

Hi @zouhir , venus hours? :-) Can you please accept the pull request.