Props removed with Clean Option

zouhir / preact-habitat

Zero configuration Preact widgets renderer in any host DOM

MIT License

518 stars 43 forks source link

Props removed with Clean Option #16

Closed stuartflanagan closed 6 years ago

stuartflanagan commented 7 years ago

When using options.clean in conjunction with props from a script tag the clean operation removes the props before the preact component is instantiated.

stuartflanagan commented 7 years ago

I will try and get a PR for this soon.

zouhir commented 7 years ago

Uh oh! good catch! in my applications I never mixed those so I am really sorry that happened! I am busy with my university until the 29th -- I'd appreciate a PR but if you are busy I can totally fix it for you after!

stuartflanagan commented 7 years ago

Happy to give it a go.

zouhir commented 7 years ago

I believe this issue should be fixed now! 😄 in #17 !!

zouhir commented 6 years ago

Fixed and I think I can safely close this!