search

zouhir / preact-habitat

Zero configuration Preact widgets renderer in any host DOM
MIT License
518 stars 43 forks source link

Allow application/json script type #43

Closed ascorbic closed 5 years ago

ascorbic commented 5 years ago

This PR adds support for application/json type for props, which is more standards-compliant and matches other uses of embedded JSON such as AMP.

ascorbic commented 5 years ago

Prettier now supports <script type="application/json">: https://github.com/prettier/prettier/pull/6293 so this would be extra useful.

lydell commented 5 years ago

Did you accidentally commit .vscode/ and dist/?

ascorbic commented 5 years ago

Ah, you're right. I did the pr from the wrong branch. I have one with dist committed so I can do a yarn install from GitHub. I'm on holiday all week so can't update the pr.

ascorbic commented 5 years ago

I've .gitignored them, but it looks like dist was actually already committed. This PR will now remove the dist directory too.

ascorbic commented 5 years ago

OK, I've actually reverted the removal of dist, because it looks like quite a few people may have been installing it directly from git, as the latest version hasn't been push to npm.