Deprecated http client method used with possible resource leak

[richard-salac]

Describe the bug API ML uses ClosableHttpClient.execute(...) method in multiple places. The method returns ClosableHttpResponse, which requires closing to prevent resource leak. The method is also deprecated (see javadoc above) due to this reason.

e.g.

• https://github.com/zowe/api-layer/blob/78e91d9c95d3cdc398c5df37dc8cc1dde81a9065/api-catalog-services/src/main/java/org/zowe/apiml/apicatalog/staticapi/StaticAPIService.java#L60
• https://github.com/zowe/api-layer/blob/78e91d9c95d3cdc398c5df37dc8cc1dde81a9065/apiml-security-common/src/main/java/org/zowe/apiml/security/common/verify/TrustedCertificatesProvider.java#L78

Suggest to replace the deprecated method with the recommended one from javadoc.

Details

• Zowe 2.18

https://github.com/zowe/api-layer/wiki/Issue-management

[balhar-jakub]

Does this issue exist also in Zowe 3.x or only in the 2.x stream?

[richard-salac]

It is valid for both.