search

zowe / cics-for-zowe-client

Monorepo for all CICS related APIs and Apps built by Zowe Clients
https://www.zowe.org/
Eclipse Public License 2.0
1 stars 3 forks source link

fix(icons-v3): Display icons for all resources #116

Closed zFernand0 closed 4 months ago

zFernand0 commented 4 months ago

What It Does

How to Test

  1. npm i
  2. npm run build
  3. Run the debugger and you should see icons now 😋

Review Checklist I certify that I have:

Additional Comments

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.17%. Comparing base (050e96f) to head (9cdd58b). Report is 2 commits behind head on next.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #116 +/- ## ======================================= Coverage 93.17% 93.17% ======================================= Files 73 73 Lines 718 718 Branches 54 55 +1 ======================================= Hits 669 669 Misses 49 49 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zFernand0 commented 4 months ago

111 is fixed in the last commit

A bit obscure, but we were creating a new instance of the profilesCache which is why the ZE instance never got the profile...

here is a debugger session of Zowe Explorer with these changes applied as part of a VSIX image

github-actions[bot] commented 4 months ago

Release failed for the next branch. :cry:

Error: The process '/opt/hostedtoolcache/node/20.11.1/x64/bin/npx' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/vsce.js:974:21)
    at ExecState.CheckComplete (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/vsce.js:960:16)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/vsce.js:863:21)
    at ChildProcess.emit (node:events:514:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

Check the workflow run for more error details.

Powered by Octorelease :rocket:

github-actions[bot] commented 4 months ago

Release succeeded for the next branch. :tada:

The following packages have been published:

Powered by Octorelease :rocket: