zowe / docs-site

Documentation for the Zowe project
https://docs.zowe.org/
Creative Commons Attribution 4.0 International
69 stars 134 forks source link

Every page on every version has the same 'last updated' date #3712

Closed ijmitch closed 3 months ago

ijmitch commented 3 months ago

Description

As per title I'm seeing every page of every version of the docs with "Last updated: 11/06/2024" - so what's the point of having that if they're all the same?

Pages to Update

Every single page!

Screenshots

image

image

And the same 'Architecture' page from an older version:

image

Expected behavior

Additional context

ijmitch commented 3 months ago

I must admit I'd not spotted the day on all the pages was actually yesterday's date - ie the day when I created this issue. Checking today, it's still saying the same thing (so it's not like this gets fixed as "today's date"). Did something happen yesterday to make all the pages appear changed?

balhar-jakub commented 3 months ago

Yes, we were publishing the 1.28.7 release yesterday, which means that all the pages were touched, but not necessarily changed.

I believe it's relevant bug to look into. Make sure that the last updated changes only for pages where content actually changed.

ijmitch commented 3 months ago

@balhar-jakub ah, OK - so at least it can be associated with an action.

So is this implemented via the showLastUpdateTime option? That should work off commit history - was there a mass commit somewhere?

ijmitch commented 3 months ago

You probably suffered this https://github.com/facebook/docusaurus/discussions/9734.

The problem is that the default depth for the actions/checkout@v4 action is 1 (latest commit only), and in this case git log cannot retrieve the dates of previous commits; instead it returns the date of the latest commit (the only one cloned), for all files, and all documentation pages appear to be updated at the same time.

Which boils down to the build process not having enough/any commit history.

balhar-jakub commented 3 months ago

I am trying fix to this in the PR - https://github.com/zowe/docs-site/pull/3715

balhar-jakub commented 3 months ago

The fix was merged and deployed. As such I am closing the issue.