Closed stevenhorsman closed 4 years ago
i believe change should go in packaging script to include the pre build binaries:
As per instructions on this page - https://www.npmjs.com/package/keyring_js
npm install
npm run prebuild
Installation
# The prebuildify tool is used to include prebuilt binaries to the package that is published to npm. That means, you can simply # # install the native addon from npm using the following command.
npm install keyring_js
npm install
npm run prebuild
The above commands are used when building from sources.
The npm package published in the npmjs registry contains the pre-built binaries so npm install keyring_js
should be sufficient.
From Nakul: ~>i checked keyring_js, it has a folder called prebuilds/os390-s390x, and that's the only prebuilds. To use this prebuilds, any projects depend on keyring_js should run npm install on zos, not linux/windows. because it doesn't ship other prebuilds on other platforms so basically, if we want to properly package keyring_js into explorer-ui-server and explorer-jes, they all need to change them to build on zos, instead what we are doing in linux container that's the proper way and when we build zowe, and put explorer-jes into zowe pax, we run npm install keyring_js again on zos i think should be in .pax/pre-packaging.sh located in zowe-install-packaging~
~I need more info and issues created so that I understand it, but so far it sounds like ~explorer-ui-server~ explorer-jes, explorer-uss & explorer-mvs builds need moving to run on z/OS and then zip build needs an extra npm install done somewhere?~
https://github.com/zowe/zlux/issues/500 covered with the new instructions
Explorer ui server, node_modules installation has been moved to z/os. Current, open issue for packaging is this: https://github.com/zowe/explorer-ui-server/issues/38
This particular issue can be closed now, as its resolved
In a recent update to the explorer ui servers (0.2.13), node_gyp has been added (via keyring_js). In the explorer-server paxes created this results in a new directory being created:
<runtime>/components/explorer-mvs/bin/server/node_modules/.bin/
which containing symbolic links to the folders that don’t exist: