Explorers are not starting with a certificate from a keyring because of missing tags for keyring_js module files - Githubissues

zowe / explorer-ui-server

Simple HTTPS web server, used by explorer UI plugins

Eclipse Public License 2.0

0 stars 2 forks source link

Explorers are not starting with a certificate from a keyring because of missing tags for keyring_js module files #38

Closed vit-tomica closed 4 years ago

vit-tomica commented 4 years ago

Explorers are failing at the line https://github.com/zowe/explorer-ui-server/blob/60bc3fd655d062cf94c9a1a0c8376225d2f5a72d/src/config.js#L21 because of new keyring_js and node-gyp-build modules in components/explorer-xxx/bin/server/node_modules path do not have files tagged as ascii (ISO8859-1).

I think building pipeline should be changed to fix the tagging.

NakulManchanda commented 4 years ago

Problem we identified is to require to reinstall node_modules on target machine with zowe 1.14 RC1

We suspect this part of packaging to be an issue: https://github.com/zowe/explorer-jes/blob/c6acfc18b6929f7cc35d11b6ebf86342ea59bb33/.pax/prepare-workspace.sh#L60

As we already install node_modules on z/os, so we can remove above line if its creating an issue https://github.com/zowe/explorer-jes/blob/c6acfc18b6929f7cc35d11b6ebf86342ea59bb33/.pax/pre-packaging.sh#L18

@jackjia-ibm suggested following: https://github.com/zowe/explorer-jes/pull/214 https://github.com/zowe/explorer-mvs/pull/143 https://github.com/zowe/explorer-uss/pull/96

Here is build with above PR's: https://wash.zowe.org:8443/view/Zowe/job/zowe-install-packaging/job/users%252Fjack%252Fexplorer-apps-tagging/

Testing:

node v6 - zowe.pax - we produced did not work we still needed to reinstall node_modules to make it work

Would be great if somebody can verify above build on - node v8 & node v12 with machine on keyring setup @stevenhorsman @vit-tomica thanks!

Above build seems to have right tagging ISO8859-1 not sure if it was not the case in RC1

ISO8859-1   T=on  -rwxr-xr-x   1 ROOT     OMVS      507904 Oct 26  1985 node.napi.node

Additionally, we are not sure why but node v6 seems to like no tagging:

- untagged    T=off -rwxr-xr-x   1 ROOT     OMVS      507904 Oct 26  1985 node.napi.node

vit-tomica commented 4 years ago

I tested the build with the following version : node v12.13.0 - OK node v8.17.0 - OK node v6.17.0 - OK Explorers worked with a keyring on all three versions.