search

zowe / ims-operations-api

The IMS Operations API is a service that provides REST APIs to manage the IMS resources required for IMS application deployment. The REST APIs invoke the IMS commands that are required to manage and query the IMS application resources.
Eclipse Public License 2.0
8 stars 2 forks source link

Jerry #8

Open th365thli opened 4 years ago

th365thli commented 4 years ago

We're changing the url from "/apis/v1" to "/api/v1" getting rid of the plural to fit with the API Mediation Layer requirements

MarkAckert commented 4 years ago

Hi Jerry, Zowe shipped the IMS CLI plugin as part of 1.9.0, which was our LTS drop - and LTS guarantees we will not have breaking changes to consumers/extenders. I don't think we shipped this REST component in 1.9.0, however, I assume this PR requires a matching set of changes to the zowe-cli-ims-plugin. Since this PR looks like it has breaking changes, I'd like to review them and the impact on our LTS releases. Thanks, cc @Joe-Winchester @armstro

Joe-Winchester commented 4 years ago

@MarkAckert - yes the IMS operations API were not shipped so are not considered yet part of Zowe LTS so a breaking change (such as this changing the API URL) is totally allowed and should go through. @th365thli - do you want me to do the Merge and thank you

MarkAckert commented 4 years ago

@Joe-Winchester I was focusing more on (my assumption) the implied breaking changes to the zowe-cli-ims-plugin we shipped with 1.9.0. If that plugin had no adopters because we didn't ship z/OS components, I think its OK to make an exception and update the IMS plugin. However, we may have a case where a user is running Zowe CLI 1.9.0 + Zowe IMS >=1.10.0 and the IMS plugin will not work as expected.

Joe-Winchester commented 4 years ago

@MarkAckert - yes the worry would be if https://www.npmjs.com/package/@zowe/ims-for-zowe-cli had been downloaded which talks to the apis and it 404s because these have now become api. @plavjanik - at one point there was talk of having the API ML "remember" APIs that have moved, with some kind of static redirect so you could define the old URL and map to the new URL , and then publish the new URL as a way of deprecating the old and encouraging the new. Is this something API ML supports currently or would that be a new addition ?