search

zowe / launcher

Eclipse Public License 2.0
0 stars 4 forks source link

Fix component enabled check not considering HA instance #121

Closed 1000TurquoisePogs closed 1 week ago

1000TurquoisePogs commented 1 week ago

Upon testing, I found that recent changes in #117 did not take HA instance into account.

I had a config like this:

components:
  zss:
    enabled: true

haInstances:
  mySys:
    components:
      zss:
        enabled: false

And witnessed the launcher would still try to start zss.

To accomodate haInstances, you must either use the user-supplied instance name, or derive it from the system name.

In this PR, I have used zowe-common-c "resolveSymbol" to get &SYSNAME when the user did not supply an ha Instance name.

The rules of zowe-install-packaging code that #117 replaces also says the sysname should be lower-case.

I tested this by varying the booleans above between true/false, and entirely omitting the haInstances object, to see what would happen.

Testing reveals a fix in the regression.

Gautham-coder commented 1 week ago

Approved.