search

zowe / sample-spring-boot-api-service

Zowe REST API service SDK and sample API service that integrates with Zowe API Mediation Layer
Other
26 stars 18 forks source link

Introduce native OS linkage example and README #16

Closed dkelosky closed 4 years ago

dkelosky commented 5 years ago

This introduces a /wto endpoint to demonstrate a JNI example within the sample spring boot API service. The example uses OS linkage to show how to call a traditional z/OS interface, WTO.

vvvlc commented 5 years ago

I understand that purpose is to demonstrate how to do OS LINKAGE and wto was selected as an example. __console2 from standard library can issue WTO as well, in order to leverage __console2 JNI code must translate utf8 to ebcdic.

dkelosky commented 5 years ago

yes, WTO was an arbitrary example - do you think some other service would be better understood ?

tucker01 commented 5 years ago

I added some comments. I think its great you guys are including this in the sample.

codecov-io commented 5 years ago

Codecov Report

Merging #16 into master will decrease coverage by 0.29%. The diff coverage is 76%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #16     +/-   ##
===========================================
- Coverage     78.49%   78.19%   -0.3%     
- Complexity       76       85      +9     
===========================================
  Files            25       29      +4     
  Lines           186      211     +25     
  Branches         21       21             
===========================================
+ Hits            146      165     +19     
- Misses           26       32      +6     
  Partials         14       14
Impacted Files Coverage Δ Complexity Δ
...in/java/org/zowe/sample/apiservice/wto/ZosWto.java 0% <0%> (ø) 0 <0> (?)
.../org/zowe/sample/apiservice/wto/WtoController.java 100% <100%> (ø) 2 <2> (?)
...java/org/zowe/sample/apiservice/wto/OffZosWto.java 100% <100%> (ø) 2 <2> (?)
...in/java/org/zowe/sample/apiservice/wto/WtoDto.java 100% <100%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a6d3e1...1e6540d. Read the comment docs.

dkelosky commented 5 years ago

thanks @gejohnston for taking the time to review - I'll take a stab at addressing both of your suggestions in this PR so that your suggestions are not lost. In time, future PRs could do more to comment on individual classes, C source, and README than my incoming updates.