Closed plavjanik closed 4 years ago
Merging #24 into master will decrease coverage by
0.65%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #24 +/- ##
============================================
- Coverage 78.85% 78.19% -0.66%
+ Complexity 117 46 -71
============================================
Files 39 21 -18
Lines 331 133 -198
Branches 21 3 -18
============================================
- Hits 261 104 -157
+ Misses 56 27 -29
+ Partials 14 2 -12
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...zowe/sample/apiservice/apidoc/ApiDocConstants.java | 0% <ø> (ø) |
0 <0> (?) |
|
...va/org/zowe/sample/apiservice/wto/WtoResponse.java | 100% <ø> (ø) |
5 <0> (?) |
|
...ple/apiservice/config/WebServerSecurityConfig.java | 100% <ø> (ø) |
3 <0> (?) |
|
...we/sample/apiservice/config/ApplicationConfig.java | 100% <ø> (ø) |
3 <0> (?) |
|
...a/org/zowe/sample/apiservice/config/WebConfig.java | 100% <ø> (ø) |
2 <0> (?) |
|
...apiservice/security/SecurityContextController.java | 100% <ø> (ø) |
2 <0> (?) |
|
...ava/org/zowe/sample/apiservice/hello/Greeting.java | 100% <ø> (ø) |
3 <0> (?) |
|
...e/sample/apiservice/ZoweApiServiceApplication.java | 33.33% <ø> (ø) |
1 <0> (?) |
|
...ava/org/zowe/sample/apiservice/CsrfController.java | 100% <ø> (ø) |
2 <0> (?) |
|
...we/sample/apiservice/config/WebSecurityConfig.java | 100% <ø> (ø) |
3 <0> (?) |
|
... and 13 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 35bb03c...39757c4. Read the comment docs.
Hello @vvvlc and @dkelosky,
the PR is ready to be reviewed. There are some possible enhancements that we have identified with @vvvlc. They have been opened as new GitHub issues so this PR is not growing more.
Resolves #5
The sample has been split into the sample (
zowe-rest-api-sample-spring
), a CLI tool (zowe-api-dev
, and a Java library (zowe-rest-api-commons-spring
).The documentation has been updated and should explain how to use it: https://github.com/zowe/sample-spring-boot-api-service/tree/sdk-split/README.md
ls -E
to show the status of attributes on z/OSsdk
in library name tocommons
zowe-api-dev
to NPMJS automaticallyzowe-rest-api-sample-spring.zip
to GitHub automaticallyjava
on z/OS (thanks @dkelosky)Post PR (opened as GitHub issues):
gh-pages
branch (GitHub Pages) - opened #26com.ca.mfaas.sdk:mfaas-common-service-core
from zowe/api-layer tocommons
here - #33