Set commit process w/ identified approvers

[1000TurquoisePogs]

Allow teams to create their own branch. Master would be managed by a small set of core contributors and is updated through pull requests. Initial membership based on people who did most commits in prior giza foundation work. Add the top two committers. If there is a third that can be added based on affiliation for now that would be ideal. Teams to decide. Sean Grady to document.

[1000TurquoisePogs]

Here are the top 2 contributors, but migrated repositories, and the links to where I found this info.

Repo	Top 2 Contributors
zlux-example-server	@1000TurquoisePogs @eamondawes
zlux-build	@eamondawes @1000TurquoisePogs
zlux-app-manager	@colavitam @1000TurquoisePogs
react-sample-app	@colavitam
imperative	@ChrisBoehmCA @AHumanFromCA
zlux-proxy-server	@1000TurquoisePogs @fkovinAtRocket
orion-editor-component	@jordanCain @jackjia-ibm
zowe-install-packaging	@Joe-Winchester @jackjia-ibm
zlux-workflow	@lchudinov @rpenny125
zlux-grid	@AlexanderMikhailovAtRocket @eamondawes
zlux-widgets	@shosen993 @rpenny125
zosmf-auth	@1000TurquoisePogs @rpenny125
tn3270-ng2	@1000TurquoisePogs @eamondawes
zlux-editor	@1000TurquoisePogs
file-transfer-app	@dprizentsov @1000TurquoisePogs
vt-ng2	@1000TurquoisePogs @rpenny125
zowe-install-test	@jackjia-ibm
explorer-mvs	@jordanCain @Colin-Stone
zos-subsystems	@rpenny125 @1000TurquoisePogs
zlux-shared	@1000TurquoisePogs @EugenyPavluk
zlux	@1000TurquoisePogs @rpenny125
workshop-user-browser-app	@1000TurquoisePogs @rpenny125
sample-iframe-app	@1000TurquoisePogs @rpenny125
zlux-ng2	@1000TurquoisePogs @rpenny125
zlux-platform	@1000TurquoisePogs @jordanfilteau1995
zss-auth	@rpenny125 @1000TurquoisePogs
explorer-server-auth	@jordanCain @stevenhorsman-ibm
zlux-file-properties	@rpenny125 @1000TurquoisePogs
workshop-starter-app	@1000TurquoisePogs @rpenny125
zlux-file-explorer	@LongBu @DivergentEuropeans
zlux-charts	@AlexanderMikhailovAtRocket @eamondawes
sample-app	@1000TurquoisePogs @EugenyPavluk
explorer-uss	@jordanCain @Colin-Stone
explorer-jes	@jordanCain @Colin-Stone
explorer-utilities	@stevenhorsman-ibm @jackjia-ibm
explorer-server	@Colin-Stone @stevenhorsman-ibm
explorer-model	@stevenhorsman-ibm @Colin-Stone
explorer-server-tests	@stevenhorsman-ibm @jackjia-ibm
rest-api-jzos-sample	@Colin-Stone @jackjia-ibm

[1000TurquoisePogs]

In the case of Rocket contributions, some of the top committers do not show up as such as a result of how we migrated code into this public github. I think the list of initial repo gatekeepers should actually be amended by the people on this list either accepting the role or recommending someone to take their place. For example: zlux-build lists myself as the second contributor but in reality, I believe @nosrednayduj knows it better than I do. Does this sound like a good plan?

[hogstrom]

As a bootstrap effort I think that will work because of the transition. I suggest that this is a limited time activity and we should lock this down in the next few weeks. Then its meritocracy based so there is no appearance of vendor movement of people in and out of the project. Does that make sense ?

Matt Hogstrom matt@hogstrom.org +1-919-656-0564 PGP Key: 0x90ECB270 Facebook https://facebook.com/matt.hogstrom LinkedIn https://linkedin/in/mhogstrom Twitter https://twitter.com/hogstrom

“It may be cognitive, but, it ain’t intuitive." — Hogstrom

On Aug 28, 2018, at 2:15 PM, Sean Grady notifications@github.com wrote:

In the case of Rocket contributions, some of the top committers do not show up as such as a result of how we migrated code into this public github. I think the list of initial repo gatekeepers should actually be amended by the people on this list either accepting the role or recommending someone to take their place. For example: zlux-build lists myself as the second contributor but in reality, I believe @nosrednayduj https://github.com/nosrednayduj knows it better than I do. Does this sound like a good plan?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zowe/zlc/issues/14#issuecomment-416743305, or mute the thread https://github.com/notifications/unsubscribe-auth/ACxXp0ZRaCMHwuNdMYOOPM-zr0twuo-nks5uVbMOgaJpZM4WOhXo.

[1000TurquoisePogs]

If there's agreement, I'd like it to be done sometime this or next week to get into a shape where we can reviewing and accepting commits from people who weren't grandfathered into the repositories. I agree that it should be meritocratic after the initial setup, but the process of change over time isn't clear to me. Such as: is each repository determining metrics of merit independently or is there a standard measurement (percentage of code that is yours over all of time or just a moving window, community vote, some other means) that the ZLC is using to guide the community? Do you have suggestions based off of working with Apache?

[rpenny125]

Sean, regarding your questions about metrics, etc. (as it relates to ongoing managing of "core contributors"), I think some of this is covered in the Zowe charter: https://zowe.org/Zowe-Charter.pdf, in the section headed "Contributors and Committers:"

Speaking of which, the terminology of the charter has:

Contributors are individuals who contribute code, fixes, tests, documentation, or other work that is part of the project. Committers have write access to the project's resources (source code repository, bug tracking system, website, build server, downloads, etc.) and are expected to influence the project's development.

@hogstrom by "core contributors", do you mean those whom the charter refers to as "committers"? If the charter terminology is non-standard, we should probably discuss that at some point.

[1000TurquoisePogs]

You're right - the charter explains this clearly. Thanks!

[Tbr00ksy]

@hogstrom @1000TurquoisePogs the on-boarding squad needs some help with committers though. For non-code related items such as website changes, content creation (tutorials, samples, etc.), Waffle/Github issue management, we need a set of committers as well. For example, @jayenzi should be a committer for Zowe.org and I need write access as the scrum master to help manage waffle tickets. Can we set up a similar process for accepting commits for non-code community assets?

[1000TurquoisePogs]

Here are the list of 3 Committers, but migrated repositories, and the links to where I found this info. This list is altered in that repositories where people from Rocket knew best, some Rocket people were swapped out for others to get a good mix of knowledge and availability. I'd recommend others do the same where they can. Some repositories did not have 3 contributors, so I added more based on who I thought had subject knowledge.

Note: substituted @dkelosky for @jhenryRocket for workshop-user-browser-app after asking @dkelosky if he preferred to be a committer or not.

Repo	Initial 3 Committers
zlux-example-server	@1000TurquoisePogs @eamondawes @fkovinAtRocket
zlux-build	@eamondawes @nosrednayduj @1000TurquoisePogs
zlux-app-manager	@colavitam @1000TurquoisePogs @lchudinov
react-sample-app	@colavitam @1000TurquoisePogs @jordanfilteau1995
imperative	@ChrisBoehmCA @AHumanFromCA @tucker01
zlux-proxy-server	@1000TurquoisePogs @fkovinAtRocket @rpenny125
orion-editor-component	@jordanCain @jackjia-ibm @stevenhorsman-ibm
zowe-install-packaging	@Joe-Winchester @jackjia-ibm @stevenhorsman-ibm
zlux-workflow	@lchudinov @rpenny125 @1000TurquoisePogs
zlux-grid	@AlexanderMikhailovAtRocket @1000TurquoisePogs @rpenny125
zlux-widgets	@rpenny125 @DenisGlebov @1000TurquoisePogs
zosmf-auth	@fkovinAtRocket @1000TurquoisePogs @rpenny125
tn3270-ng2	@1000TurquoisePogs @eamondawes @rpenny125
zlux-editor	@colavitam @jordanfilteau1995 @1000TurquoisePogs
file-transfer-app	@dprizentsov @jordanfilteau1995 @1000TurquoisePogs
vt-ng2	@1000TurquoisePogs @eamondawes @rpenny125
zowe-install-test	@jackjia-ibm @Joe-Winchester ? @stevenhorsman-ibm ?
explorer-mvs	@jordanCain @Colin-Stone @stevenhorsman-ibm
zos-subsystems	@rpenny125 @1000TurquoisePogs @joenemo
zlux-shared	@1000TurquoisePogs @rpenny125 @colavitam
zlux	@1000TurquoisePogs @rpenny125 @colavitam
workshop-user-browser-app	@1000TurquoisePogs @rpenny125 @jhenryRocket
sample-iframe-app	@1000TurquoisePogs @rpenny125 @colavitam
zlux-ng2	@1000TurquoisePogs @rpenny125 @colavitam
zlux-platform	@1000TurquoisePogs @colavitam @rpenny125
zss-auth	@fkovinAtRocket @rpenny125 @1000TurquoisePogs
explorer-server-auth	@jordanCain @stevenhorsman-ibm @1000TurquoisePogs ?
zlux-file-properties	@rpenny125 @1000TurquoisePogs @colavitam
workshop-starter-app	@1000TurquoisePogs @rpenny125 @jhenryRocket
zlux-file-explorer	@rpenny125 @colavitam @1000TurquoisePogs
zlux-charts	@AlexanderMikhailovAtRocket @rpenny125 @1000TurquoisePogs
sample-app	@1000TurquoisePogs @rpenny125 @jordanfilteau1995
explorer-uss	@jordanCain @Colin-Stone @stevenhorsman-ibm
explorer-jes	@jordanCain @Colin-Stone @stevenhorsman-ibm
explorer-utilities	@stevenhorsman-ibm @jackjia-ibm @jordanCain
explorer-server	@Colin-Stone @stevenhorsman-ibm @jackjia-ibm
explorer-model	@stevenhorsman-ibm @Colin-Stone @jackjia-ibm
explorer-server-tests	@stevenhorsman-ibm @jackjia-ibm @Colin-Stone
rest-api-jzos-sample	@Colin-Stone @jackjia-ibm @stevenhorsman-ibm

[1000TurquoisePogs]

Completed this by implementing Committer teams and locking down master to require pull request approvals.