zowe / zen

Eclipse Public License 2.0
1 stars 6 forks source link

Test vsam stcs tabs #247

Open Himani1519 opened 2 months ago

Himani1519 commented 2 months ago

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zen/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

PR Checklist

Please delete options that are not relevant.

Testing

Further comments

struga0258 commented 2 weeks ago

The new code changes pushed in this PR break existing test, this PR is not ready for merge and needs to be fixed.

  1. You have replaced setup.js with setup.ts not sure why, but then you have renamed some of the functions which are now causing errors.
  2. We had spoke about this before but going from zos-node-accessor to node-ssh might be the easy solution but it comes with limitations that will not help us debug and test Zen properly.
  3. You have added two new test, Stcs and Vsam, but they are both missing 'prepare_enviroment'. This is probably why you didn't get the errors from setup.ts.
  4. The test also need to be improved for the new test files you added, they can be improved and test better.