search

zowe / zlux

The top-level superproject for zLUX. zLUX includes the Zowe Desktop framework in addition to several built-in apps and an example server implementation.
Eclipse Public License 2.0
39 stars 42 forks source link

Adjust ZSS static APIML registration for localhost operation #516

Closed 1000TurquoisePogs closed 3 years ago

1000TurquoisePogs commented 3 years ago

https://github.com/zowe/zss/pull/208 added static apiml registration for ZSS. In the default case for ZSS, it runs on localhost instead of on a public IP In the case of Docker, or other non-default cases, ZSS could run on a public IP (defined by ZWED_agent_http_ipAddresses) Modify the static registration to make use of that value to allow ZSS to be reachable through APIML when the IP does not match the value of ZOWE_EXPLORER_HOST. Also, detect if ATTLS is on, as to whether or not the address is "http" or "https", which can be detected by ZWED_agent_http_attls=true or not.

In my testing, it seemed like setting the value of instanceBaseUrls to use localhost or 127.0.0.1 were ignored and the value of ZOWE_EXPLORER_HOST was used instead, so there may be a feature request for APIML squad if this does not work as expected.

1000TurquoisePogs commented 3 years ago

This has been made obsolete by the TLS support which registers ZSS to ZOWE_EXPLORER_HOST now.