zowe / zlux

The top-level superproject for zLUX. zLUX includes the Zowe Desktop framework in addition to several built-in apps and an example server implementation.
Eclipse Public License 2.0
39 stars 42 forks source link

Editor: Improve File Tree Icons and stylings #574

Open NakulManchanda opened 3 years ago

NakulManchanda commented 3 years ago

Improve styles and adopt new professional icons for zlux-file-angular-tree

ZLUX File tree icons can borrow some styles and ideas from zowe vscode extension

We can improve on file icons even further - to have language specific icons image

USS View - Zowe Explorer image

USS View - ZLUX Editor image

Dataset View - Zowe Explorer image

Dataset View - ZLUX Editor image

Some suggestions from @DivergentEuropeans :

DivergentEuropeans commented 3 years ago

Here are my thoughts!

USS doesn't look like it needs that much work imo. I'm not a huge fan of the language-specific icons that VS Code has because I don't find them that useful & sometimes distracting, instead I find myself using/viewing

  1. the file names which tell me type/extension and
  2. the search feature (Ctrl + P) to open files instead. Navigating through directories & folders, expanding/collapsing takes time. I think we could get more value by adding a search function that searches through currently visible nodes & displays those that match the search. The search could be optimized to be quick (searches visible nodes & their already expanded children) or advanced (opens unopened folders behind the scenes, and searches them) I created an issue for this here: https://github.com/zowe/zlux/issues/580 We could still do language-specific icons for USS if we'd like, but I wouldn't label it high priority

Datasets I agree could use some work. By the DS name, there is no obvious distinction between the datasets you're viewing. These should have icons that differentiate between PDS, VSAM, PDS/E etc etc I've already done similar work to this in the past for a different app & would love to contribute again here

NakulManchanda commented 3 years ago

hi @DivergentEuropeans ,

Thanks, adding them to list above

the search feature (Ctrl + P) to open files instead. By the DS name, there is no obvious distinction between the datasets you're viewing. These should have icons that differentiate between PDS, VSAM, PDS/E etc

In addition,

Thanks for reviewing.