zowe / zlux

The top-level superproject for zLUX. zLUX includes the Zowe Desktop framework in addition to several built-in apps and an example server implementation.
Eclipse Public License 2.0
39 stars 42 forks source link

Zowe Editor loads resources from fonts.gstatic.com that fail in a restricted environment (Browser with no internet access) #960

Open lv198 opened 1 year ago

lv198 commented 1 year ago

Describe the bug The Zowe Editor loads resources from fonts.gstatic.com. When using Zowe Desktop in a restricted environment (Web Browser has no internet access), this fails. For example, you see the word "Clear" instead of an "X" at the top right corner (see screenshot).

Steps to Reproduce

  1. Disconnect Web Browser from internet
  2. Edit a file in Zowe Editor
  3. You will see the described behaviour.

Expected behavior Zowe should not load any resources from another source. All files needed to run Zowe should be delivered with Zowe.

Screenshots (if needed) grafik

Describe your environment

Additional context

1000TurquoisePogs commented 1 year ago

I can reproduce this, and will bring it up to the team for assignment.

1000TurquoisePogs commented 1 year ago

I found the occurrences here https://github.com/zowe/zlux-editor/search?q=gstatic It looks like we can swap the URL references to url(/something/off/app-server/) Where we get the library from npm here https://www.npmjs.com/package/material-icons and then package it into our web directory via webpack copy like so https://github.com/zowe/zlux-editor/blob/2daf253c47b1f3781424db253157c88e2c7dedfb/webClient/webpack.build.config.js#L73-L76