zowe / zlux

The top-level superproject for zLUX. zLUX includes the Zowe Desktop framework in addition to several built-in apps and an example server implementation.
Eclipse Public License 2.0
38 stars 42 forks source link

Should Zowe Desktop skip the login page if redirected from Gateway with apimlAuthenticationToken cookie already set? #970

Closed pablocarle closed 1 year ago

pablocarle commented 1 year ago

Describe the bug

If SSO is enabled with API ML, it shouldn't prompt for user credentials considering apimlAuthenticationToken is already set when accessing through the gateway.

Steps to Reproduce

  1. Login to gateway through API Catalog:
  2. Open Zowe Application Server tile: image
  3. Open service homepage: image

Or go to https://:/zlux/api/v1

  1. It will show Zowe Desktop login page and set cookie connect.sid.1

Expected behavior

If SSO is enabled with API ML, it shouldn't prompt for user credentials considering apimlAuthenticationToken is already set.

Screenshots (if needed)

Describe your environment

1000TurquoisePogs commented 1 year ago

Thank you. I agree and this must be a regression but not sure when. I see the if (request.body) of the auth-handler returns true because its {} and I think it was undefined before. I can reproduce this so I will submit some PRs soon.

1000TurquoisePogs commented 1 year ago

I believe this may satisfy the request zowe.jfrog.io/zowe/libs-snapshot-local/org/zowe/2.9.0-PR-3418/zowe-2.9.0-pr-3418-3084-20230511150533.pax

pablocarle commented 1 year ago

Hi @1000TurquoisePogs, I was trying this on the released 2.9.0 PAX and I find that's still requiring going through the desktop's login page, did it make it into this release?