search

zowe / zowe-chat

Zowe Chat Ops
Eclipse Public License 2.0
4 stars 3 forks source link

Implement architecture code for Zowe Chat - logging #33

Closed Wusong-Fang closed 2 years ago

Wusong-Fang commented 2 years ago

Implement architecture code for Zowe Chat - logging

MarkAckert commented 2 years ago

I suggest looking at how Imperative handled logging in a common framework - https://github.com/zowe/imperative , under packages/logging. Imperative solves a similar problem as a library providing common functions to downstream extenders (CLI and its plugins). We don't have to use Log4js like Imperative did - I don't have a strong opinion on the specific framework since they appear to have relative parity at a glance - but the structure in Imperative's logging code could be used as inspiration.

Wusong-Fang commented 2 years ago

@MarkAckert Thanks a lot for the suggestion. winston library is used as logging framework in common bot framework. I'm thinking to use it for zowe chat - core and plugins too. I think we can discuss more on that after most of the architecture code is ready. Thanks!