zowe / zowe-cli-cics-plugin

Migrated to zowe/cics-for-zowe-client.

https://github.com/zowe/cics-for-zowe-client

Eclipse Public License 2.0

7 stars 11 forks source link

Apiml conn lookup next #100

Closed gejohnston closed 3 years ago

gejohnston commented 3 years ago

Add apimlConnLookup properties to enable auto-config through APIML. A valid apiId for CICS must still be identified.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

codecov[bot] commented 3 years ago

Codecov Report

Merging #100 (d9d2822) into next (922b98e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #100   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files          74       74           
  Lines         760      760           
  Branches       90       90           
=======================================
  Hits          711      711           
  Misses         49       49

Impacted Files	Coverage Δ
src/imperative.ts	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62429c0...d9d2822. Read the comment docs.

t1m0thyj commented 3 years ago

If we had to guess what the API IDs are for Zowe plugins, I'd guess "com.ibm.cics", "com.ibm.ims", "com.ibm.mq". These all can be found on the Internet if you do a Google search for them.

But this may just be because of Java naming conventions, and I assume we want to know the IDs for certain rather than guessing. Even for z/OSMF, we have used different values in the past - "ibm.zosmf" currently, but in the past we documented "com.ibm.zosmf" (source). This makes me curious - would it be useful to support wildcards on the apimlConnLookup object like "*ibm.zosmf"?

All this to say, I agree with the decision for now to leave the API IDs defined as a placeholder value.