search

zowe / zowe-cli-cics-plugin

Migrated to zowe/cics-for-zowe-client.
https://github.com/zowe/cics-for-zowe-client
Eclipse Public License 2.0
7 stars 11 forks source link

Removed npm-shrinkwrap.json as it was causing the plugin install to f… #40

Closed PeteSwauger closed 5 years ago

PeteSwauger commented 5 years ago

…ail with 'Maximum call stack size exceeded'

codecov[bot] commented 5 years ago

Codecov Report

Merging #40 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          42       42           
  Lines         403      403           
  Branches       48       48           
=======================================
  Hits          364      364           
  Misses         39       39

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5edae14...d54949b. Read the comment docs.

PeteSwauger commented 5 years ago

If the file is removed (and unnecessary) why should it be ignored? I do believe I still had the problem when I just had the ignore in .gitignore but not 100% certain.

zFernand0 commented 5 years ago

If the file is removed (and unnecessary) why should it be ignored? I do believe I still had the problem when I just had the ignore in .gitignore but not 100% certain.

It's so that it does not make its way into source unless someone explicitly takes it off from the gitignore