zowe / zowe-cli-cics-plugin

Migrated to zowe/cics-for-zowe-client.
https://github.com/zowe/cics-for-zowe-client
Eclipse Public License 2.0
7 stars 11 forks source link

Add install and discard URIMAPs, fix enable and disable URIMAPs #71

Closed awharn closed 4 years ago

awharn commented 4 years ago
  1. Add the install and discard urimap commands
  2. Add the install and discard urimap system and unit tests
  3. Add an option to define urimap to allow URIMAPs to be installed as disabled
  4. Fix the existing enable and disable urimap commands to function properly
  5. Update existing unit and system tests to reflect the proper order of the tests
  6. Update test snapshots
  7. Remove duplicate system tests

This PR fixes #48, fixes #51

codecov[bot] commented 4 years ago

Codecov Report

Merging #71 into master will increase coverage by 0.3%. The diff coverage is 97.95%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #71     +/-   ##
=========================================
+ Coverage    93.4%   93.71%   +0.3%     
=========================================
  Files          62       66      +4     
  Lines         637      684     +47     
  Branches       75       80      +5     
=========================================
+ Hits          595      641     +46     
- Misses         42       43      +1
Impacted Files Coverage Δ
src/api/methods/disable/Disable.ts 100% <ø> (ø) :arrow_up:
src/cli/disable/urimap/Urimap.definition.ts 100% <ø> (ø) :arrow_up:
src/cli/enable/urimap/Urimap.handler.ts 100% <ø> (ø) :arrow_up:
...c/cli/define/urimap-server/UrimapServer.handler.ts 100% <ø> (ø) :arrow_up:
...li/define/urimap-server/UrimapServer.definition.ts 100% <ø> (ø) :arrow_up:
...efine/urimap-pipeline/UrimapPipeline.definition.ts 100% <ø> (ø) :arrow_up:
src/cli/enable/urimap/Urimap.definition.ts 100% <ø> (ø) :arrow_up:
...li/define/urimap-client/UrimapClient.definition.ts 100% <ø> (ø) :arrow_up:
...c/cli/define/urimap-client/UrimapClient.handler.ts 100% <ø> (ø) :arrow_up:
src/cli/-strings-/en.ts 100% <ø> (ø) :arrow_up:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3018baa...1612031. Read the comment docs.

codecov-io commented 4 years ago

Codecov Report

Merging #71 into master will increase coverage by 0.3%. The diff coverage is 97.95%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #71     +/-   ##
=========================================
+ Coverage    93.4%   93.71%   +0.3%     
=========================================
  Files          62       66      +4     
  Lines         637      684     +47     
  Branches       75       80      +5     
=========================================
+ Hits          595      641     +46     
- Misses         42       43      +1
Impacted Files Coverage Δ
src/api/methods/disable/Disable.ts 100% <ø> (ø) :arrow_up:
src/cli/disable/urimap/Urimap.definition.ts 100% <ø> (ø) :arrow_up:
src/cli/enable/urimap/Urimap.handler.ts 100% <ø> (ø) :arrow_up:
...c/cli/define/urimap-server/UrimapServer.handler.ts 100% <ø> (ø) :arrow_up:
...li/define/urimap-server/UrimapServer.definition.ts 100% <ø> (ø) :arrow_up:
...efine/urimap-pipeline/UrimapPipeline.definition.ts 100% <ø> (ø) :arrow_up:
src/cli/enable/urimap/Urimap.definition.ts 100% <ø> (ø) :arrow_up:
...li/define/urimap-client/UrimapClient.definition.ts 100% <ø> (ø) :arrow_up:
...c/cli/define/urimap-client/UrimapClient.handler.ts 100% <ø> (ø) :arrow_up:
src/cli/-strings-/en.ts 100% <ø> (ø) :arrow_up:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3018baa...6070326. Read the comment docs.

awharn commented 4 years ago

Thanks for improving and cleaning up the integration tests as part of this 👍

Looks good overall, all of the changes I suggested are minor.

Just to be sure, is it correct that the sleep's done during system tests are necessary even when they are run in-band, to ensure that the tables are no longer locked?

Yes, the sleeps are necessary as the install and enable commands seem to take awhile longer to release their lock on the table.