zowe / zowe-cli-cics-plugin

Migrated to zowe/cics-for-zowe-client.

https://github.com/zowe/cics-for-zowe-client

Eclipse Public License 2.0

7 stars 11 forks source link

bugfix/feature: system tests respect protocol, use HTTPS if none defined #78

Closed awharn closed 4 years ago

awharn commented 4 years ago

Updates the system tests to use either the protocol specified in the custom_properties.json file in all tests, or use HTTPS if none is specified. This prepares the project for coming changes to default the CICS Plugin to use secure (HTTPS) connections.

Signed-off-by: Andrew W. Harn andrew.harn@broadcom.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #78 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          74       74           
  Lines         749      749           
  Branches       86       86           
=======================================
  Hits          706      706           
  Misses         43       43

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c72bb43...33e75a3. Read the comment docs.

zFernand0 commented 4 years ago

@awharn, could you also update the example properties? https://github.com/zowe/zowe-cli-cics-plugin/blob/c72bb432f5a8dc8845edbe9c1c74bc43739a4271/__tests__/__resources__/properties/example_properties.yaml#L26

zFernand0 commented 4 years ago

@awharn, could you also update the example properties? https://github.com/zowe/zowe-cli-cics-plugin/blob/c72bb432f5a8dc8845edbe9c1c74bc43739a4271/__tests__/__resources__/properties/example_properties.yaml#L26

Or maybe we leave this when we are actually implementing the defaults ??

zFernand0 commented 4 years ago

Oh, thanks for doing it!