search

zowe / zowe-cli-db2-plugin

DB2 Plugin for the Zowe CLI
Eclipse Public License 2.0
8 stars 16 forks source link

Migrate to zowe namespace #20

Closed ChrisBoehmCA closed 5 years ago

ChrisBoehmCA commented 5 years ago

Fix #17

Migrate the plugin to @zowe namespace (change package name to @zowe/db2 and import from @zowe/imperative instead of @brightside/imperative). These changes are only for the master/ latest branch and can't be ported to lts-incremental as the package name change is breaking and @zowe/cli and @zowe/imperative will only be available on the @daily and @latest tags

Also Fix #12

I wasn't able to run the unit tests. I get a lot of errors like this: 

 Error
      Error: The specified module could not be found.
      \\?\C:\nodejs\zowe-cli-db2-plugin\node_modules\ibm_db\build\Release\odbc_bindings.node

Could @nurra01 or @vasev01 please check out this branch and see if you're able to run the unit tests and any other tests you have?

nurra01 commented 5 years ago

I have cloned and run npm install, and got this error: Capture

nurra01 commented 5 years ago

and tests are failing with the same error you had

ChrisBoehmCA commented 5 years ago

Hmm, that seems related to the ibm db driver. Do you get the same error on master (I get the same failing tests on master)? I don't think I did anything that would affect the db driver

nurra01 commented 5 years ago

I got the same. Have you tried it in Linux ?

ChrisBoehmCA commented 5 years ago

I have not. I can try later to see if it works on Linux

vasev01 commented 5 years ago

Chris, I can install and run unit tests under Linux. Only tests in DB2Sessions.test.ts are failing due to missed SESSION.username field.

vasev01 commented 5 years ago

db2install db2test-unit

ChrisBoehmCA commented 5 years ago

I updated the unit tests. Hopefully that fixes it

ChrisBoehmCA commented 5 years ago

OK. The tests all passed on Linux for me just now. Is the driver installation just harder on Windows? I don't think the failure was introduced by this PR since it also fails on master for me but maybe somebody should look into the Windows failures

image