zowe / zowe-cli-ftp-plugin

Zowe CLI FTP Plugin
Eclipse Public License 2.0
16 stars 12 forks source link

fix list spool file hang problem. #159

Closed tiantn closed 4 months ago

tiantn commented 4 months ago

What It Does

How to Test

Review Checklist I certify that I have:

Additional Comments

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (next@4dea27d). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #159 +/- ## ======================================= Coverage ? 73.49% ======================================= Files ? 77 Lines ? 981 Branches ? 128 ======================================= Hits ? 721 Misses ? 240 Partials ? 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

tiantn commented 4 months ago

This looks similar to the following PR:

* [Fix issue #156 to return proper message for active job #157](https://github.com/zowe/zowe-cli-ftp-plugin/pull/157)

Thanks for porting and enhancing the functionality and error message.

Curious if we can link the same issue on the changelog (issue number #156)

Hi @zFernand0, I think it fixed the issue #158 😊

tiantn commented 4 months ago

Hi @zFernand0 , @traeok , @std4lqi , thank you for your review and good suggestions. I updated the code to check the files length as well. And also update unit test for no spool file scenario to improve test cover rate. Thank you!

zFernand0 commented 4 months ago

Merging without DCO check. See below issue for details 😋

Kudos to @traeok

github-actions[bot] commented 4 months ago

Release succeeded for the next branch. :tada:

The following packages have been published:

Powered by Octorelease :rocket: