search

zowe / zowe-cli-ftp-plugin

Zowe CLI FTP Plugin
Eclipse Public License 2.0
16 stars 12 forks source link

Added --rdw to `download dataset` command to download variable-length dataset #74

Closed std4lqi closed 3 years ago

std4lqi commented 3 years ago

To support #58

Signed-off-by: Qi Liang 31643673+std4lqi@users.noreply.github.com

dkelosky commented 3 years ago

This seems to work for me 😄 . In testing on windows, the file is downloaded with x'0D0A' carriage return & line feed. These two bytes are not included in the rdw.

lauren-li commented 3 years ago

Thanks @std4lqi for adding this feature! Functionally, this PR seems to work for me. I am able to get RDW values in my downloaded data sets using the new --rdw option. There are a couple minor merge conflicts, but they should be able to be resolved without affecting the function of this PR.

The automated tests are mostly passing for me, but there may be a snapshot that needs to be updated:

Screen Shot 2021-04-27 at 1 20 57 PM
std4lqi commented 3 years ago

@lauren-li I updated snapshot for --rdw. Thanks!

std4lqi commented 3 years ago

@dkelosky Thanks for your testing! We use rdw heavily for binary variable length dataset.

Usually, the EOL is appended in the dataset downloaded with ASCII, so even without rdw, we still can tell the end of record (text line in this case) with EOL. From my view, TRANSFER_TYPE_ASCII_RDW is not so useful, but I incline to adding for consistency, or there is some case I'm not aware of.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication