Closed zFernand0 closed 3 years ago
Hi @zFernand0, I just run the unit test and system test with this PR. And I found all the snapshots of --help test case failed due to I upgrade the zowe CLI to the latest version and there is a minor update in help part. See the picture below. So I updated the snapshots in another PR based on your branch. https://github.com/zowe/zowe-cli-ftp-plugin/pull/89 Could you help to review it? Thank you!
Wondering about the package-lock file. Should we update it to version 2 (npm7) or keep it on version 1 (npm6)?
I believe Node 16 (which includes npm7) becomes LTS in October.
I'm ok if we do this now or later. :yum:
Wondering about the package-lock file. Should we update it to version 2 (npm7) or keep it on version 1 (npm6)?
I believe Node 16 (which includes npm7) becomes LTS in October.
I'm ok if we do this now or later. 😋
Wondering about the package-lock file. Should we update it to version 2 (npm7) or keep it on version 1 (npm6)?
I believe Node 16 (which includes npm7) becomes LTS in October.
I'm ok if we do this now or later. 😋
Hi @zFernand0 , I am also ok. You can follow your prefered. 😊
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
We can continue to use the package-lock version 1 for now (until node16 becomes LTS for real :yum: Thanks @tiantn for making the PR to the GHA branch to update the snapshots! :wink:
Signed-off-by: zFernand0 fernando.rijocedeno@broadcom.com