zowe / zowe-cli-ftp-plugin

Zowe CLI FTP Plugin
Eclipse Public License 2.0
16 stars 12 forks source link

Add GitHub Actions #88

Closed zFernand0 closed 3 years ago

zFernand0 commented 3 years ago

Signed-off-by: zFernand0 fernando.rijocedeno@broadcom.com

tiantn commented 3 years ago

Hi @zFernand0, I just run the unit test and system test with this PR. And I found all the snapshots of --help test case failed due to I upgrade the zowe CLI to the latest version and there is a minor update in help part. See the picture below. So I updated the snapshots in another PR based on your branch. https://github.com/zowe/zowe-cli-ftp-plugin/pull/89 图片 Could you help to review it? Thank you!

zFernand0 commented 3 years ago

Wondering about the package-lock file. Should we update it to version 2 (npm7) or keep it on version 1 (npm6)?

I believe Node 16 (which includes npm7) becomes LTS in October.

I'm ok if we do this now or later. :yum:

tiantn commented 3 years ago

Wondering about the package-lock file. Should we update it to version 2 (npm7) or keep it on version 1 (npm6)?

I believe Node 16 (which includes npm7) becomes LTS in October.

I'm ok if we do this now or later. 😋

Wondering about the package-lock file. Should we update it to version 2 (npm7) or keep it on version 1 (npm6)?

I believe Node 16 (which includes npm7) becomes LTS in October.

I'm ok if we do this now or later. 😋

Hi @zFernand0 , I am also ok. You can follow your prefered. 😊

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

zFernand0 commented 3 years ago

We can continue to use the package-lock version 1 for now (until node16 becomes LTS for real :yum: Thanks @tiantn for making the PR to the GHA branch to update the snapshots! :wink: