zowe / zowe-cli-scs-plugin

The secure credential store plugin for Zowe CLI, leveraging keytar and the OS keychain to securely access and store sensitive user credentials normally stored in CLI profiles.
Eclipse Public License 2.0
8 stars 3 forks source link

README file: updated SWR's for the plug-in #51

Closed JamesBauman closed 2 years ago

JamesBauman commented 2 years ago

Windows installs for npm7/8 must be connected to the internet and issue npm install -g prebuild-install command

JamesBauman commented 2 years ago

My DCO does not appear to be working on this repo. It's working ok on zowe docs-site.

Is it a desktop configuration issue or user error?

I pasted Signed-off-by: JamesBauman james.bauman@broadcom.com into the comments box when i committed using Git Desktop.....

t1m0thyj commented 2 years ago

My DCO does not appear to be working on this repo. It's working ok on zowe docs-site.

Is it a desktop configuration issue or user error?

I pasted Signed-off-by: JamesBauman james.bauman@broadcom.com into the comments box when i committed using Git Desktop.....

The 2nd commit (568b5a2) on this PR is signed off correctly, but the 1st one (8601193) appears to be missing a signoff. Looks like the 1st commit may have been created using the GitHub web UI, which doesn't include signoff automatically?

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

JamesBauman commented 2 years ago

DCO is not working correct.. Closing this PR and will create a new PR.