zowe / zowe-cli-scs-plugin

The secure credential store plugin for Zowe CLI, leveraging keytar and the OS keychain to securely access and store sensitive user credentials normally stored in CLI profiles.
Eclipse Public License 2.0
8 stars 3 forks source link

chore: use Secrets SDK instead of keytar #73

Closed traeok closed 1 year ago

traeok commented 1 year ago

What It Does

This PR replaces keytar with the Secrets SDK keyring module.

How to Test

Install v1 of the CLI from this PR, and then install the SCS plugin from this branch (npm run installPlugin). Reviewers should be able to execute a CLI command, e.g. zowe files list ds ... with a v1 profile that's already set up, and the CLI should be able to access the secured credentials.

Review Checklist I certify that I have:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/credentials/KeytarCredentialManager.ts 100.00%

:loudspeaker: Thoughts on this report? Let us know!.

github-actions[bot] commented 1 year ago

Release succeeded for the master branch. :tada:

The following packages have been published:

Powered by Octorelease :rocket: