zowe / zowe-cli-secrets-for-kubernetes

Eclipse Public License 2.0
0 stars 0 forks source link

solve tough-cookie dependency issue #33

Closed rudyflores closed 7 months ago

rudyflores commented 8 months ago

What It Does

Solves #32

Updated outdated dependencies, bumped npm version to 9.8.1 and node to 18.18.2 in order to provide supported versions since 16 seems to have reached EOL.

this fix for tough-cookie dependency will use the @kubernetes/client-node version 1.0.0-rc4of the API in order to use the fetch implementation mentioned in their repo instead of the deprecated and now vulnerable package of request the version 0.20.0 has. Once v1.0.0 is released we can bump that version to that, but for the time being this can be used as a temporary fix for a critical vulnerability.

How to Test

Run

plugin should install and work just as before

Review Checklist I certify that I have:

Additional Comments

rudyflores commented 8 months ago

Sorry I may have approved prematurely - noticed that system tests in the Ubuntu build started failing with:

Error: 24/01/10 19:23:36.160] [ERROR] [CredentialManagerFactory.js:149] Failed to load the credential manager named "Secrets for Kubernetes"
Error: 24/01/10 19:23:36.167] [ERROR] [CredentialManagerFactory.js:151] Error: Namespace default does not exist

Maybe fixing #15 would help to troubleshoot this - I suspect the real error isn't "Namespace does not exist", but something else which is currently missing from the error message.

Seems to be related to self signed certs, I'm looking into refactoring some code across the K8sCredentialManager.ts file to prevent this