zowe / zowe-cli-secrets-for-kubernetes

Eclipse Public License 2.0
0 stars 0 forks source link

Release `v0.1.3` #34

Closed rudyflores closed 7 months ago

rudyflores commented 7 months ago

What It Does

Prepare release v0.1.3 with much needed vulnerability fixes

How to Test

Review Checklist I certify that I have:

Additional Comments

rudyflores commented 7 months ago

@t1m0thyj do you know why the changelog check keeps failing? I formatted the changelog to look similar to how the changelog looks in ZE but it seems to still fail 🤔

traeok commented 7 months ago

do you know why the changelog check keeps failing? I formatted the changelog to look similar to how the changelog looks in ZE but it seems to still fail 🤔

Could it be that the changelog check is looking for ## Recent Changes instead of ## TBD Release for the header? I noticed that the check printed an error about a missing header, but I wasn't sure if that was the header causing issues.

t1m0thyj commented 7 months ago

Could it be that the changelog check is looking for ## Recent Changes instead of ## TBD Release for the header? I noticed that the check printed an error about a missing header, but I wasn't sure if that was the header causing issues.

Good catch @traeok! If we want the required changelog header to be ## TBD Release to be consistent with Zowe Explorer, we can change it in the workflow here: https://github.com/zowe/zowe-cli-secrets-for-kubernetes/blob/506e755e9eb9967e9ccb9c141aad1473170d3254/.github/workflows/changelog.yml#L21-L23

rudyflores commented 7 months ago

@t1m0thyj @traeok thanks for the help! I added as well a changelog the vscode package and added the fix for the error #15 that Timothy created a while back and was addressed in this new version :)

github-actions[bot] commented 7 months ago

Release succeeded for the main branch. :tada:

The following packages have been published:

Powered by Octorelease :rocket: