Consider deprecating `cpage` in favor of encoding - Githubissues

zowe / zowe-cli

Zowe CLI

Eclipse Public License 2.0

108 stars 86 forks source link

Consider deprecating `cpage` in favor of encoding #1430

Open zFernand0 opened 2 years ago

zFernand0 commented 2 years ago

Based on this discussion: https://github.com/zowe/vscode-extension-for-zowe/issues/1815#issuecomment-1131767799

Should we research if it's worth deprecating codePage in favor of encoding

https://github.com/zowe/zowe-cli/blob/c0ab0d80b4adcb4c58a32b2379df219213e44767/packages/zostso/src/TsoConstants.ts#L43

FALLAI-Denis commented 2 years ago

Hi,

I'm not sure if it's appropriate to change the name of the codePage property for the tso profile.

The encoding declarations for the zosmf and tso profiles are not identical:

the zosmf profile uses only one property: encoding
the tso profile uses two properties: codePage and characterSet

Having different property names between the zosmf and tso profiles helps to keep in mind thecharacterSetproperty declaration for the tso profile.

Put another way :

codePage requires the declaration of a characterSet
encoding stands on its own