Flattening imperative - Githubissues

zowe / zowe-cli

Zowe CLI

Eclipse Public License 2.0

108 stars 85 forks source link

Flattening imperative #2035

Closed ATorrise closed 5 months ago

ATorrise commented 5 months ago

What It Does

Flattens zowe-cli/packages/imperative
- takes tests out of src
- removes redundant file structure ie src/packageName/src
- an effort towards standardizing imperative's structure to that of other packages' structure
Allows 1 ts-configuration file to apply over entire zowe-cli/packages/imperative/__tests__
Is part of the clean-up effort for v3

Review Checklist I certify that I have:

[ ] tested my changes
[ ] added/updated automated tests
[ ] updated the changelog
[ ] followed the contribution guidelines

Additional Comments

Unsure about how to incorporate changelog
fixing up imperative package inspired by previous tsconfig-related PR

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3c5918e) 91.05% compared to head (5ee7479) 77.94%. Report is 4 commits behind head on next.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## next #2035 +/- ## =========================================== - Coverage 91.05% 77.94% -13.12% =========================================== Files 634 634 Lines 18540 18549 +9 Branches 3860 3857 -3 =========================================== - Hits 16882 14458 -2424 - Misses 1657 4090 +2433 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ATorrise commented 5 months ago

Closing because I don't think this needs to be as hard as I've made it, also the changes with profile removal Gene made aren't reflected because of all the files I've moved around. Basically saying that I should wait to do this flattening and it should be done quickly so that other people can still work simultaneously