zowe / zowe-cli

Zowe CLI
Eclipse Public License 2.0
113 stars 87 forks source link

Remove RECFM checks and add version output #2038

Closed awharn closed 7 months ago

awharn commented 7 months ago

What It Does

Resolves #1699 by removing all RECFM validation during data-set creation. Resolves #2028 by adding additional output to zowe --version

How to Test

  1. Issue zowe --version
  2. Issue zowe files create data-set with an invalid record format

Review Checklist I certify that I have:

Additional Comments

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2fd6396) 91.07% compared to head (2055048) 91.07%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2038 +/- ## ========================================== - Coverage 91.07% 91.07% -0.01% ========================================== Files 634 634 Lines 18540 18517 -23 Branches 3859 3730 -129 ========================================== - Hits 16885 16864 -21 + Misses 1654 1652 -2 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

awharn commented 7 months ago

This PR leaves a check in place to ensure variable blocked data-sets are created with a block size at least 4 blocks larger then the logical record length. This is because z/OSMF will still create the data-set, but it will not be able to store any records. (#1727)

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud