Closed traeok closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1b972d7
) 91.06% compared to head (7ff571b
) 91.06%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
Measures
0 Security Hotspots
92.6% Coverage on New Code
0.0% Duplication on New Code
Release succeeded for the master
branch. :tada:
The following packages have been published:
@zowe/imperative@5.22.3
@zowe/cli-test-utils@7.23.3
@zowe/core-for-zowe-sdk@7.23.3
@zowe/zos-uss-for-zowe-sdk@7.23.3
@zowe/provisioning-for-zowe-sdk@7.23.3
@zowe/zos-console-for-zowe-sdk@7.23.3
@zowe/zos-files-for-zowe-sdk@7.23.3
@zowe/zos-logs-for-zowe-sdk@7.23.3
@zowe/zosmf-for-zowe-sdk@7.23.3
@zowe/zos-workflows-for-zowe-sdk@7.23.3
@zowe/zos-jobs-for-zowe-sdk@7.23.3
@zowe/zos-tso-for-zowe-sdk@7.23.3
@zowe/cli@7.23.3
Powered by Octorelease :rocket:
What It Does
Resolves #2051
Since we allow command-based schemas to be registered through Zowe Explorer, the comparison checks between schemas need to omit any command-related properties to prevent the equality checks from failing.
Otherwise, the warning regarding "two unversioned schemas with different contents" will persist as the equality check will always fail. This PR resolves this by ignoring any command-based properties when comparing schemas.
Ideally, we would make
initForZowe
in Zowe Explorer API use theIProfileTypeConfiguration
type instead ofICommandProfileTypeConfiguration
- unfortunately, this would be a breaking change, so the best we can do for now is make comparisons and ignore the properties from the command-based type.Review Checklist I certify that I have: