zowe / zowe-cli

Zowe CLI
Eclipse Public License 2.0
108 stars 85 forks source link

Add missing yields and other fixes #2055

Closed awharn closed 4 months ago

awharn commented 4 months ago

What It Does

Fixes SonarCloud bugs

How to Test

Review Checklist I certify that I have:

Additional Comments

codecov[bot] commented 4 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2a4cba2) 91.06% compared to head (52ea428) 91.07%. Report is 1 commits behind head on master.

Files Patch % Lines
...ckages/imperative/src/imperative/src/Imperative.ts 97.29% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2055 +/- ## ======================================= Coverage 91.06% 91.07% ======================================= Files 636 636 Lines 18967 18965 -2 Branches 3910 3976 +66 ======================================= - Hits 17273 17272 -1 + Misses 1693 1692 -1 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
48.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

awharn commented 4 months ago

Unfortunately, there is no good way to tell if this fixes all the bugs on SonarCloud or not. More work may need to be done after this PR is merged.