zowe / zowe-cli

Zowe CLI
Eclipse Public License 2.0
108 stars 85 forks source link

Fix plug-in peerDep check #2067

Closed zFernand0 closed 4 months ago

zFernand0 commented 4 months ago

What It Does

Remove the warnings at plug-in install time that appear, even though the plug-in peerDep version-range satisfies the requirement.

How to Test

First you would want to reproduce the issue:

Then you can test this branch:

Review Checklist I certify that I have:

Additional Comments

This follows the same behavior as https://semver.npmjs.com/

Also, this GIF might make things easier to review: temp

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.93%. Comparing base (b840120) to head (2e1d2d0). Report is 1 commits behind head on next.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2067 +/- ## ======================================= Coverage 90.93% 90.93% ======================================= Files 616 616 Lines 17359 17359 Branches 3671 3672 +1 ======================================= Hits 15786 15786 Misses 1572 1572 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zFernand0 commented 4 months ago

This PR can wait until after to following PR is merged into next to avoid any confusion/conflicts πŸ˜‹

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 4 months ago

Release succeeded for the next branch. :tada:

The following packages have been published:

Powered by Octorelease :rocket: