zowe / zowe-cli

Zowe CLI
Eclipse Public License 2.0
108 stars 85 forks source link

fix(ProfileInfo): remove `@internal` from `layerActive` #2068

Closed traeok closed 4 months ago

traeok commented 4 months ago

What It Does

We did not have stripInternal on the tsconfig.json in the past, so even though some functions and variables were marked with @internal, those comments were simply ignored during compilation. Since recent work in Zowe Explorer uses the layerActive function for converting v1 profiles, I've removed the @internal from this function's TSDoc.

No changelog was added as the behavior remains the same as previous v3 snapshots and v2 by removing @internal.

How to Test

No specific scenario to test - should be able to build and run tests.

Review Checklist I certify that I have:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.08%. Comparing base (5d71e2f) to head (1c72830).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2068 +/- ## ======================================= Coverage 91.08% 91.08% ======================================= Files 638 638 Lines 18828 18828 Branches 3856 3921 +65 ======================================= Hits 17150 17150 Misses 1677 1677 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions[bot] commented 4 months ago

Release succeeded for the next branch. :tada:

The following packages have been published:

Powered by Octorelease :rocket: