zowe / zowe-cli

Zowe CLI
Eclipse Public License 2.0
108 stars 85 forks source link

Remove the 'zowe profiles' command command handlers & APIs #2073

Closed gejohnston closed 4 months ago

gejohnston commented 4 months ago

What It Does

This PR removes the command handlers for the zowe profiles command group.

Also:

How to Test

  1. Commands should continue to run as before when no configuration exists or a team configuration exists. Commands should ignore V1 profiles, even when they are the only available configuration. In particular, if only V1 profiles exist, running a Zowe command now will prompt the user for connection information.
    > zowe files list data-set "SYS1.PARMLIB*"
    Enter the host name of your service: YourHostName
    Enter the user name for your service (will be hidden):
    Enter the password for your service (will be hidden):
  2. Use --show-inputs-only, config report-env, & config convert-profiles and observe that no references to V1 or V2 profiles are displayed.

Follow-ups

Review Checklist I certify that I have:

Additional Comments

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.70833% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 90.93%. Comparing base (230203e) to head (a38c22d).

Files Patch % Lines
...perative/src/cmd/src/profiles/CliProfileManager.ts 81.57% 7 Missing :warning:
...es/imperative/src/config/src/ProfileCredentials.ts 20.00% 4 Missing :warning:
packages/imperative/src/config/src/ConfigUtils.ts 90.90% 1 Missing :warning:
packages/imperative/src/config/src/ProfileInfo.ts 98.61% 1 Missing :warning:
...c/imperative/src/config/cmd/report-env/EnvQuery.ts 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2073 +/- ## ========================================== - Coverage 91.09% 90.93% -0.16% ========================================== Files 638 616 -22 Lines 18840 17358 -1482 Branches 3814 3613 -201 ========================================== - Hits 17162 15785 -1377 + Misses 1677 1572 -105 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
60.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

github-actions[bot] commented 4 months ago

Release succeeded for the next branch. :tada:

The following packages have been published:

Powered by Octorelease :rocket: