Ssh error - Githubissues

ATorrise commented 4 months ago

What It Does Fixes https://github.com/zowe/zowe-cli/issues/1031 :

enables addition of user/password to ssh profile (which will never support apiml) when apimltoken is present in base
provides better error message for debugging connectivity to plugins. not possible to be precise as plugins manage themselves differently and it will not always be clear why connectivity is unsuccessful. Failure could be due to any of the 3 options when an apiml token is present:
- service failure
- apiml is not supported by that plugin (not easy for us to programatically discern)
- invalid/expired credentials or properties

How to Test

For vscode launch.json

{
    "type": "node",
    "request": "launch",
    "name": "ssh error",
    "program": "${workspaceFolder}/zowe-cli/packages/cli/lib/main.js",
    "console": "integratedTerminal",
    "args": ["zos-uss", "issue", "ssh", "echo test"],
    "outputCapture": "std",
    "resolveSourceMapLocations": null
},

Regular command: zowe zos-uss issue ssh "echo test"

Review Checklist I certify that I have:

[x] tested my changes
[x] added/updated automated tests
[x] updated the changelog
[x] followed the contribution guidelines

Additional Comments Handling connectivity errors with other plugins that aren't yet supported by apiml should be a topic for discussion amongst team (ie: CICS and MQ)

Result of PR:

New error handling for other plugins apiml doesn't support AND that have yet to implement supportedAuthTypes?: AUTH_TYPE_CHOICES[]

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.93%. Comparing base (4e08fa7) to head (777a558).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## next #2081 +/- ## ========================================== - Coverage 90.94% 90.93% -0.01% ========================================== Files 616 616 Lines 17386 17393 +7 Branches 3621 3586 -35 ========================================== + Hits 15811 15817 +6 - Misses 1574 1575 +1 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.