Fix api for uploading buffer to uss file

zowe / zowe-cli

Zowe CLI

Eclipse Public License 2.0

108 stars 85 forks source link

Fix api for uploading buffer to uss file #2089

Closed t1m0thyj closed 3 months ago

t1m0thyj commented 3 months ago

What It Does

LTS Breaking: Changed return type of Upload.bufferToUssFile to return IZosFilesResponse object instead of string
BugFix: Fixed Upload.bufferToUssFile not normalizing new lines when uploading plain text

How to Test Zowe CLI doesn't call this API so no easy way to test it there. However we should be able to test it in FileSystemProvider PR for Zowe Explorer 😋 https://github.com/zowe/zowe-explorer-vscode/pull/2777

Review Checklist I certify that I have:

[ ] tested my changes
[x] added/updated automated tests
[x] updated the changelog
[ ] followed the contribution guidelines

Additional Comments

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.93%. Comparing base (152262f) to head (ecb6b09). Report is 2 commits behind head on next.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## next #2089 +/- ## ======================================= Coverage 90.93% 90.93% ======================================= Files 616 616 Lines 17377 17386 +9 Branches 3676 3579 -97 ======================================= + Hits 15801 15810 +9 Misses 1575 1575 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

awharn commented 3 months ago

Remember to update the breaking change document with the renamed input. :)

sonarcloud[bot] commented 3 months ago

Quality Gate failed

Failed conditions
20.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud