zowe / zowe-cli

Zowe CLI
Eclipse Public License 2.0
108 stars 85 forks source link

provided requested fix to `zos-jobs list --help-examples` #2092

Closed ATorrise closed 3 months ago

ATorrise commented 3 months ago

What It Does

How to Test run zos-jobs list --help-examples to see string concatenation issue resolved Review Checklist I certify that I have:

Additional Comments Picked this up just because of the optics of our overwhelming amount of "issues that need help" listed under the cli (these issues are what we have tagged as good first issues) compared to other zowe repos image

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.92%. Comparing base (789a0a3) to head (cc9f1b2). Report is 1 commits behind head on next.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2092 +/- ## ======================================== Coverage 90.91% 90.92% ======================================== Files 616 616 Lines 17348 17348 Branches 3682 3582 -100 ======================================== + Hits 15772 15773 +1 + Misses 1575 1574 -1 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ATorrise commented 3 months ago

Thanks for picking this up. 🥳 Should this be rebased to master (and then ported over to next)? (or just ported over to master) 🤔 LGTM! 😋

Probably master and then ported? @zFernand0

zFernand0 commented 3 months ago

Since there was a very recent deployment on master I think it's fine to go with next and then port to master We can merge said port tomorrow 😋